Add support for odoc comment syntax for ReasonML comments#477
Open
ArneSchulze wants to merge 2 commits intojaredly:masterfrom
Open
Add support for odoc comment syntax for ReasonML comments#477ArneSchulze wants to merge 2 commits intojaredly:masterfrom
ArneSchulze wants to merge 2 commits intojaredly:masterfrom
Conversation
Signed-off-by: ArneSchulze <arne.artur.schulze@sap.com>
ArneSchulze
commented
Dec 3, 2021
| }; */ | ||
|
|
||
| let process = (~uri, ~moduleName, ~basePath, ~reasonFormat, text, ~cacheLocation, ~compilerVersion, ~allLocations, compilerPath, refmtPath, includes, flags) => { | ||
| let process = (~uri, ~moduleName, ~basePath, ~reasonFormat, text, ~cacheLocation, ~compilerVersion, ~allLocations, compilerPath, refmtPath, includes, flags, converter) => { |
Author
There was a problem hiding this comment.
Providing a converter as argument is supposed to make sure that documentation comments for local symbols also display text in the correct format. Previously the doc comment text was passed around as-is, so that displaying only worked for markdown comments, not for odoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
odoccomment syntax forReasonMLdocumentation comments. The support is disabled by default but can be enabled using theuse_odoc_for_reasonconfiguration.